Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-648 Add wandb and neptune dependencies #5842

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Oct 11, 2024

Why are the changes needed?

These dependencies are needed to get the flytekit docs to build with the added neptune and wandb plugins.

This is one of three PRs we need to merge in the following order to get the neptune and wandb flytekit plugin docs onto the docs site:

  1. flytesnacks PR to fix refs in neptune and wandb plugin docs
  2. flyte PR (this one) to update monodocs dependencies
  3. flytekit PR to add new flytekit plugin docs for neptune and wandb plugins (after re-running monodocs build)

What changes were proposed in this pull request?

Updated monodocs-environment.yaml and monodocs-environment.lock.yaml with neptune and wandb dependencies.

How was this patch tested?

Recreated my monodocs-env conda environment with the new lockfile, then ran make docs withFLYTEKIT_LOCAL_PATH set to my branch with the new neptune and wandb plugin docs.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytekit#2803

Docs link

TK

@neverett neverett self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.35%. Comparing base (197ae13) to head (6fff557).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5842      +/-   ##
==========================================
+ Coverage   34.48%   36.35%   +1.86%     
==========================================
  Files        1138     1304     +166     
  Lines      102742   110148    +7406     
==========================================
+ Hits        35434    40046    +4612     
- Misses      63634    65935    +2301     
- Partials     3674     4167     +493     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.26% <ø> (?)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 42.02% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett merged commit 003b8de into master Oct 14, 2024
50 checks passed
@neverett neverett deleted the nikki/docs/test-adding-neptune-dep branch October 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants