Update ray.go not to fail when going suspend state. #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a Queue to schedule our ray jobs, so we need it to wait in Suspended state of k8s Signed-off-by: Amin Maghsodi <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5816 +/- ##
==========================================
+ Coverage 36.35% 36.81% +0.45%
==========================================
Files 1304 1309 +5
Lines 110147 130899 +20752
==========================================
+ Hits 40042 48184 +8142
- Misses 65938 78533 +12595
- Partials 4167 4182 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amin Maghsodi <[email protected]>
Improve test cov Signed-off-by: Amin Maghsodi <[email protected]>
aminmaghsodi
changed the title
pingsutw
previously approved these changes
Oct 16, 2024
pingsutw
reviewed
Oct 18, 2024
| @@ -755,7 +755,8 @@ func TestGetTaskPhase(t *testing.T) { | |||
| {rayv1.JobDeploymentStatusRunning, pluginsCore.PhaseRunning, false}, | |||
| {rayv1.JobDeploymentStatusComplete, pluginsCore.PhaseSuccess, false}, | |||
| {rayv1.JobDeploymentStatusFailed, pluginsCore.PhasePermanentFailure, false}, | |||
| {rayv1.JobDeploymentStatusSuspended, pluginsCore.PhaseUndefined, true}, | |||
| {rayv1.JobDeploymentStatusSuspended, pluginsCore.PhaseQueued, true}, | |||
| {rayv1.JobDeploymentStatusSuspending, pluginsCore.PhaseUndefined, true}, | |||
There was a problem hiding this comment.
@aminmaghsodi could we map it to pluginsCore.PhaseQueued as well?
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
Oct 23, 2024
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a Queue to schedule our ray jobs, so we need it to wait in Suspended state of k8s
Now workflow fails, exactly when job state goes to 'Suspended'