Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] add copy command examples and description #5782

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mao3267
Copy link
Contributor

@mao3267 mao3267 commented Sep 27, 2024

Related PRs

flyteorg/flytekit#2715

Why are the changes needed?

Update the documents for users to understand the copy commands behaviors and usages.

What changes were proposed in this pull request?

  1. Added a simple workflow example of using imageSpec with copy commands.
  2. Describe the expected behavior and usages.

How was this patch tested?

  1. The examples are tested through remote execution.
pyflyte run --remote build_image.py my_wf

Screenshots

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

TODO

Sorry, something went wrong.

Signed-off-by: mao3267 <chenvincent610@gmail.com>
@mao3267 mao3267 marked this pull request as ready for review September 27, 2024 02:31
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.31%. Comparing base (c0cb4d1) to head (542aae7).
Report is 68 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5782      +/-   ##
==========================================
- Coverage   36.31%   36.31%   -0.01%     
==========================================
  Files        1304     1304              
  Lines      110016   110016              
==========================================
- Hits        39950    39948       -2     
- Misses      65909    65911       +2     
  Partials     4157     4157              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.62% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.89% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops merged commit 96c467e into flyteorg:master Nov 5, 2024
50 checks passed
Copy link

welcome bot commented Nov 5, 2024

Congrats on merging your first pull request! 🎉

@mao3267 mao3267 deleted the copy-command-doc branch November 7, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants