Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments for semver regex #5758

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add comments for semver regex #5758

merged 1 commit into from
Sep 18, 2024

Conversation

pmahindrakar-oss
Copy link
Contributor

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: pmahindrakar-oss <[email protected]>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.29%. Comparing base (2d9c35b) to head (689843b).
Report is 157 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5758      +/-   ##
==========================================
- Coverage   36.30%   36.29%   -0.01%     
==========================================
  Files        1305     1305              
  Lines      109997   109997              
==========================================
- Hits        39930    39927       -3     
- Misses      65911    65914       +3     
  Partials     4156     4156              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.62% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.88% <ø> (ø)
unittests-flytestdlib 55.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@katrogan katrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@pmahindrakar-oss pmahindrakar-oss enabled auto-merge (squash) September 18, 2024 18:48
@pmahindrakar-oss pmahindrakar-oss merged commit 792ce1a into master Sep 18, 2024
50 checks passed
@pmahindrakar-oss pmahindrakar-oss deleted the semver-comments branch September 18, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants