Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker/build-push-action to v6 #5747

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Sep 14, 2024

Tracking issue

N/A

Why are the changes needed?

  1. Generate a job summary in GHA for your build that outlines the execution and materials used. It improves the visibility & readability for build information. (By default, it will generate summary and upload the build record archive to GitHub. We can disable them via "DOCKER_BUILD_SUMMARY" and "DOCKER_BUILD_RECORD_UPLOAD" env variables.)

  2. Remove the warning "The following actions use a deprecated Node.js version and will be forced to run on node20"

  3. refs:
    https://www.docker.com/blog/new-beta-feature-deep-dive-into-github-actions-docker-builds-with-docker-desktop/
    https://docs.docker.com/build/ci/github-actions/build-summary

What changes were proposed in this pull request?

Use the latest docker/build-push-action

How was this patch tested?

test in ci
image

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.31%. Comparing base (59bf191) to head (7b68d15).
Report is 127 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5747      +/-   ##
==========================================
+ Coverage   36.21%   36.31%   +0.09%     
==========================================
  Files        1303     1304       +1     
  Lines      109644   110016     +372     
==========================================
+ Hits        39710    39948     +238     
- Misses      65810    65911     +101     
- Partials     4124     4157      +33     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.62% <ø> (+0.02%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.89% <ø> (+0.13%) ⬆️
unittests-flytestdlib 55.37% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

pingsutw
pingsutw previously approved these changes Sep 20, 2024
Signed-off-by: Ryan Lo <[email protected]>
@lowc1012 lowc1012 force-pushed the bump-build-push-action branch from 66f3e82 to 7b68d15 Compare September 27, 2024 11:44
@eapolinario eapolinario merged commit 5d792c0 into flyteorg:master Nov 22, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants