-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listing api to stow storage #5741
Merged
wild-endeavor
merged 5 commits into
flyteorg:master
from
bgedik:bugra.gedik/add_storage_listing_api
Sep 12, 2024
Merged
Add listing api to stow storage #5741
wild-endeavor
merged 5 commits into
flyteorg:master
from
bgedik:bugra.gedik/add_storage_listing_api
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugra Gedik <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5741 +/- ##
=======================================
Coverage 36.21% 36.22%
=======================================
Files 1303 1303
Lines 109568 109644 +76
=======================================
+ Hits 39683 39719 +36
- Misses 65765 65801 +36
- Partials 4120 4124 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wild-endeavor
previously approved these changes
Sep 12, 2024
3 tasks
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
wild-endeavor
approved these changes
Sep 12, 2024
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Part of RFC https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend
Why are the changes needed?
Deterministic error propagation, see: https://github.com/flyteorg/flyte/blob/b3add894fd879d6b6c11e37ba292ae04bf60afeb/rfc/system/5598-deterministic-errors-distributed-training.md#flytepropeller-backend
What changes were proposed in this pull request?
Adding listing APIs
How was this patch tested?
Unit tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#5616
Docs link
N/A