Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flyteadmin to pass proto structs as pointers #5717

Merged
merged 4 commits into from
Sep 5, 2024

fix integration test

0f75532
Select commit
Loading
Failed to load commit list.
Merged

Refactor flyteadmin to pass proto structs as pointers #5717

fix integration test
0f75532
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 3, 2024 in 0s

36.20% (+0.03%) compared to 7a91799

View this Pull Request on Codecov

36.20% (+0.03%) compared to 7a91799

Details

Codecov Report

Attention: Patch coverage is 72.05624% with 159 lines in your changes missing coverage. Please review.

Project coverage is 36.20%. Comparing base (7a91799) to head (0f75532).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
flyteadmin/pkg/manager/mocks/signal_interface.go 14.28% 9 Missing and 9 partials ⚠️
...ytepropeller/pkg/compiler/common/mocks/workflow.go 0.00% 16 Missing ⚠️
...ller/pkg/compiler/common/mocks/workflow_builder.go 17.64% 8 Missing and 6 partials ⚠️
...cloudevent/implementations/cloudevent_publisher.go 0.00% 6 Missing ⚠️
flyteadmin/pkg/rpc/adminservice/attributes.go 40.00% 6 Missing ⚠️
flytepropeller/pkg/compiler/common/mocks/task.go 0.00% 6 Missing ⚠️
flyteadmin/pkg/manager/impl/workflow_manager.go 73.68% 5 Missing ⚠️
flyteadmin/pkg/manager/impl/execution_manager.go 91.30% 2 Missing and 2 partials ⚠️
flyteadmin/pkg/manager/impl/launch_plan_manager.go 80.00% 4 Missing ⚠️
flyteadmin/pkg/manager/mocks/metrics_interface.go 0.00% 4 Missing ⚠️
... and 40 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5717      +/-   ##
==========================================
+ Coverage   36.17%   36.20%   +0.03%     
==========================================
  Files        1303     1303              
  Lines      109663   109543     -120     
==========================================
- Hits        39667    39657      -10     
+ Misses      65851    65768      -83     
+ Partials     4145     4118      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov