Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Try Serverless" language in Quickstart guide #5698

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Aug 27, 2024

What changes were proposed in this pull request?

Updates language in the "Try Flyte in your browser" section of the Quickstart guide.

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

Signed-off-by: nikki everett <[email protected]>
@neverett neverett self-assigned this Aug 27, 2024
@neverett neverett requested a review from ppiegaze as a code owner August 27, 2024 15:37
@neverett neverett changed the title update langauge Update "Try Serverless" language in Quickstart guide Aug 27, 2024
@neverett neverett requested a review from EngHabu August 27, 2024 15:38
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.18%. Comparing base (7136919) to head (b34d9a4).
Report is 164 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5698   +/-   ##
=======================================
  Coverage   36.18%   36.18%           
=======================================
  Files        1302     1302           
  Lines      109614   109614           
=======================================
  Hits        39660    39660           
  Misses      65809    65809           
  Partials     4145     4145           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.33% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.18% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.34% <ø> (ø)
unittests-flytepropeller 41.71% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/quickstart_guide.md Outdated Show resolved Hide resolved
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Nikki Everett <[email protected]>
@neverett
Copy link
Contributor Author

@EngHabu I accepted your suggestion, can you review again? Thanks!

@pingsutw pingsutw merged commit 5b6bd52 into master Sep 5, 2024
50 checks passed
@pingsutw pingsutw deleted the nikki/edit-try-flyte branch September 5, 2024 06:58
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
* update langauge

Signed-off-by: nikki everett <[email protected]>

* Update docs/quickstart_guide.md

Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Nikki Everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Nikki Everett <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
* update langauge

Signed-off-by: nikki everett <[email protected]>

* Update docs/quickstart_guide.md

Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Nikki Everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Nikki Everett <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
bgedik pushed a commit to bgedik/flyte that referenced this pull request Sep 12, 2024
* update langauge

Signed-off-by: nikki everett <[email protected]>

* Update docs/quickstart_guide.md

Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Nikki Everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Nikki Everett <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants