-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Try Serverless" language in Quickstart guide #5698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikki everett <[email protected]>
neverett
changed the title
update langauge
Update "Try Serverless" language in Quickstart guide
Aug 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5698 +/- ##
=======================================
Coverage 36.18% 36.18%
=======================================
Files 1302 1302
Lines 109614 109614
=======================================
Hits 39660 39660
Misses 65809 65809
Partials 4145 4145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EngHabu
reviewed
Aug 27, 2024
Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Nikki Everett <[email protected]>
@EngHabu I accepted your suggestion, can you review again? Thanks! |
pingsutw
approved these changes
Sep 2, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
* update langauge Signed-off-by: nikki everett <[email protected]> * Update docs/quickstart_guide.md Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Nikki Everett <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Nikki Everett <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
* update langauge Signed-off-by: nikki everett <[email protected]> * Update docs/quickstart_guide.md Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Nikki Everett <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Nikki Everett <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Sep 12, 2024
* update langauge Signed-off-by: nikki everett <[email protected]> * Update docs/quickstart_guide.md Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Nikki Everett <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Nikki Everett <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updates language in the "Try Flyte in your browser" section of the Quickstart guide.
Check all the applicable boxes
Docs link