Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added literal offloading for array node map tasks #5697

Merged
merged 9 commits into from
Sep 16, 2024

nit

4a03f91
Select commit
Loading
Failed to load commit list.
Merged

Added literal offloading for array node map tasks #5697

nit
4a03f91
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 16, 2024 in 1s

36.29% (+0.07%) compared to 89efcc6

View this Pull Request on Codecov

36.29% (+0.07%) compared to 89efcc6

Details

Codecov Report

Attention: Patch coverage is 80.59701% with 26 lines in your changes missing coverage. Please review.

Project coverage is 36.29%. Comparing base (89efcc6) to head (4a03f91).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...lytepropeller/pkg/controller/nodes/common/utils.go 78.18% 8 Missing and 4 partials ⚠️
flytepropeller/pkg/controller/config/config.go 75.00% 4 Missing ⚠️
...propeller/pkg/apis/flyteworkflow/v1alpha1/iface.go 0.00% 2 Missing ⚠️
...epropeller/pkg/compiler/transformers/k8s/inputs.go 66.66% 2 Missing ⚠️
flytepropeller/pkg/controller/controller.go 0.00% 2 Missing ⚠️
...ytepropeller/pkg/controller/nodes/array/handler.go 71.42% 1 Missing and 1 partial ⚠️
flytepropeller/pkg/controller/nodes/executor.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5697      +/-   ##
==========================================
+ Coverage   36.21%   36.29%   +0.07%     
==========================================
  Files        1303     1305       +2     
  Lines      109568   109991     +423     
==========================================
+ Hits        39683    39924     +241     
- Misses      65764    65912     +148     
- Partials     4121     4155      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov