More concise definition of launchplan #5682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5682 +/- ##
==========================================
+ Coverage 36.16% 36.18% +0.01%
==========================================
Files 1302 1302
Lines 109523 109558 +35
==========================================
+ Hits 39614 39645 +31
- Misses 65772 65773 +1
- Partials 4137 4140 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
neverett
previously approved these changes
Aug 22, 2024
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]>
neverett
approved these changes
Aug 23, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
Sep 9, 2024
* More concise definition of launchplan Signed-off-by: Eduardo Apolinario <[email protected]> * Update docs/flyte_fundamentals/tasks_workflows_and_launch_plans.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Update docs/flyte_fundamentals/tasks_workflows_and_launch_plans.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
bgedik
pushed a commit
to bgedik/flyte
that referenced
this pull request
Sep 12, 2024
* More concise definition of launchplan Signed-off-by: Eduardo Apolinario <[email protected]> * Update docs/flyte_fundamentals/tasks_workflows_and_launch_plans.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> * Update docs/flyte_fundamentals/tasks_workflows_and_launch_plans.md Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This section in the docs is the only explanation of what launchplans are and its current version is not clear. This PR proposes a rephrasing of that definition.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link