Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listing to stow storage apis #5674

Closed
wants to merge 69 commits into from
+242 −2

Merge branch 'bugra.gedik/add_listing_to_storage_apis' of github.com:…

16454bf
Select commit
Loading
Failed to load commit list.
Closed

Add listing to stow storage apis #5674

Merge branch 'bugra.gedik/add_listing_to_storage_apis' of github.com:…
16454bf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2024 in 1s

36.22% (+0.00%) compared to 86c63f7

View this Pull Request on Codecov

36.22% (+0.00%) compared to 86c63f7

Details

Codecov Report

Attention: Patch coverage is 43.42105% with 43 lines in your changes missing coverage. Please review.

Project coverage is 36.22%. Comparing base (86c63f7) to head (16454bf).

Files with missing lines Patch % Lines
...ytestdlib/storage/mocks/composed_protobuf_store.go 0.00% 27 Missing ⚠️
flytestdlib/storage/stow_store.go 67.74% 6 Missing and 4 partials ⚠️
flyteadmin/pkg/common/mocks/storage.go 0.00% 2 Missing ⚠️
flytepropeller/pkg/utils/failing_datastore.go 0.00% 2 Missing ⚠️
flytestdlib/storage/mem_store.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5674   +/-   ##
=======================================
  Coverage   36.21%   36.22%           
=======================================
  Files        1303     1303           
  Lines      109568   109644   +76     
=======================================
+ Hits        39683    39715   +32     
- Misses      65765    65805   +40     
- Partials     4120     4124    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov