Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Update resource failures w/ Finalizers set (#423) #5673
[Bug] Update resource failures w/ Finalizers set (#423) #5673
Changes from all commits
d374648
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 484 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L481-L484
Check warning on line 486 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L486
Check warning on line 490 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L489-L490
Check warning on line 497 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L496-L497
Check warning on line 501 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L499-L501
Check warning on line 504 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L503-L504
Check warning on line 506 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L506
Check warning on line 510 in flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
Codecov / codecov/patch
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go#L510