Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-533 Remove outdated duplicate notification config content #5672

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

neverett
Copy link
Contributor

What changes were proposed in this pull request?

Remove outdated duplicate content and link to deployment docs notification config page.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

TK

@neverett neverett requested a review from eapolinario August 19, 2024 22:46
@neverett neverett self-assigned this Aug 19, 2024
@neverett neverett requested a review from ppiegaze as a code owner August 19, 2024 22:46
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.17%. Comparing base (d797f08) to head (cb59e71).
Report is 149 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5672       +/-   ##
===========================================
+ Coverage    9.74%   36.17%   +26.42%     
===========================================
  Files         214     1302     +1088     
  Lines       39190   109492    +70302     
===========================================
+ Hits         3820    39608    +35788     
- Misses      35031    65746    +30715     
- Partials      339     4138     +3799     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.33% <ø> (?)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.32% <ø> (?)
unittests-flyteidl 7.08% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (?)
unittests-flytepropeller 41.74% <ø> (?)
unittests-flytestdlib 55.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett neverett merged commit 5042404 into master Aug 20, 2024
50 checks passed
@neverett neverett deleted the nikki/DOC-533-remove-duplicate-page branch August 20, 2024 14:16
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
…ation config page (#5672)

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants