Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offloaded path to literal #5660

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Add offloaded path to literal #5660

merged 1 commit into from
Aug 14, 2024

Conversation

katrogan
Copy link
Contributor

Why are the changes needed?

see RFC proposal here: #5103

What changes were proposed in this pull request?

Updates literal proto message only.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Katrina Rogan <[email protected]>
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36.17%. Comparing base (4f9227a) to head (a5cefa0).
Report is 135 commits behind head on master.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/literals.pb.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5660   +/-   ##
=======================================
  Coverage   36.16%   36.17%           
=======================================
  Files        1302     1302           
  Lines      109484   109492    +8     
=======================================
+ Hits        39600    39606    +6     
- Misses      65746    65748    +2     
  Partials     4138     4138           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.33% <ø> (+0.03%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (ø)
unittests-flyteidl 7.08% <0.00%> (-0.01%) ⬇️
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.74% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrogan
Copy link
Contributor Author

@eapolinario okay to merge despite the codecov check?

@eapolinario
Copy link
Contributor

@eapolinario okay to merge despite the codecov check?

yeah. Just merged. I'll cut a flyteidl release as soon as this lands.

@eapolinario eapolinario merged commit 3d38729 into master Aug 14, 2024
49 of 50 checks passed
@eapolinario eapolinario deleted the offloaded-literals branch August 14, 2024 18:27
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants