Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-462 Update "Try Flyte in the browser" text #5654

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Aug 12, 2024

Why are the changes needed?

TK

What changes were proposed in this pull request?

TK

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

https://flyte--5654.org.readthedocs.build/en/5654/quickstart_guide.html

Signed-off-by: nikki everett <[email protected]>
@neverett neverett self-assigned this Aug 12, 2024
@neverett neverett requested a review from ppiegaze as a code owner August 12, 2024 15:42
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.17%. Comparing base (96bbf7e) to head (b956eca).
Report is 147 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5654      +/-   ##
==========================================
- Coverage   36.17%   36.17%   -0.01%     
==========================================
  Files        1302     1302              
  Lines      109428   109492      +64     
==========================================
+ Hits        39589    39605      +16     
- Misses      65703    65749      +46     
- Partials     4136     4138       +2     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.33% <ø> (+0.04%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.08% <ø> (-0.01%) ⬇️
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.74% <ø> (ø)
unittests-flytestdlib 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nikki everett <[email protected]>
pingsutw
pingsutw previously approved these changes Aug 16, 2024
```{button-link} https://sandbox.union.ai/
Union Serverless is a hosted version of Flyte that you can try in your browser. To get started, see the [Union Serverless Quickstart guide](https://docs.union.ai/serverless/quick-start).

```{button-link} https://serverless.union.ai/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should give link to the signup instead of the direct url to serverless as we are still gating access to this. Signup.union.ai is where they join the waitlist and once approved they get mail with instructions on accessing serverless which includes that url

nikki everett added 2 commits August 16, 2024 11:53
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
@neverett
Copy link
Contributor Author

@pingsutw @pmahindrakar-oss updated the copy to link to the waitlist instead and made the whole thing more concise. Let me know what you think!

@neverett neverett merged commit d797f08 into master Aug 16, 2024
50 checks passed
@neverett neverett deleted the nikki/DOC-462-update-try-flyte-browser-text branch August 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants