Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error when attempting to trigger schedules for inactive projects #5649

regen

38fba77
Select commit
Loading
Failed to load commit list.
Merged

Don't error when attempting to trigger schedules for inactive projects #5649

regen
38fba77
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 12, 2024 in 1s

36.17% (-0.01%) compared to 9cfb4e3, passed because coverage increased by -0.01% when compared to adjusted base (36.18%)

View this Pull Request on Codecov

36.17% (-0.01%) compared to 9cfb4e3, passed because coverage increased by -0.01% when compared to adjusted base (36.18%)

Details

Codecov Report

Attention: Patch coverage is 25.00000% with 45 lines in your changes missing coverage. Please review.

Project coverage is 36.17%. Comparing base (9cfb4e3) to head (38fba77).

Files Patch % Lines
flyteidl/gen/pb-go/flyteidl/admin/project.pb.go 2.63% 37 Missing ⚠️
flyteadmin/scheduler/executor/executor_impl.go 58.33% 3 Missing and 2 partials ⚠️
flyteadmin/pkg/errors/errors.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5649      +/-   ##
==========================================
- Coverage   36.18%   36.17%   -0.01%     
==========================================
  Files        1302     1302              
  Lines      109428   109484      +56     
==========================================
+ Hits        39594    39608      +14     
- Misses      65699    65738      +39     
- Partials     4135     4138       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.