Upstream Using InMemory token cache for admin clientset in propeller #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#299) * Using InMmeory token cache for admin clientset in propeller * pass cache to auth interceptor Signed-off-by: Paul Dittamo <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5621 +/- ##
==========================================
+ Coverage 36.17% 36.29% +0.12%
==========================================
Files 1302 1302
Lines 109405 109666 +261
==========================================
+ Hits 39575 39808 +233
- Misses 65694 65705 +11
- Partials 4136 4153 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
2 tasks
wild-endeavor
approved these changes
Aug 20, 2024
pmahindrakar-oss
added a commit
that referenced
this pull request
Sep 9, 2024
…#299) (#5621) Signed-off-by: Paul Dittamo <[email protected]> Co-authored-by: Prafulla Mahindrakar <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This is an upstream of a fix that caused a panic in our fork. The source of the panic is the
nilvalue set fortokenCachewhen propeller is making the auth interceptor.Something misleading is happening here though... this panic'ing auth interceptor is not actually being used. These dial options are being returned up to the
authOptsvariable here. TheseauthOptsare then only used when talking to data catalog. Data catalog is typically not authenticated, so this panic doesn't happen.The actual auth interceptor that is being used by propeller is here, in the main client builder code. This one is proactively set to a TokenCacheInMemory if nil which is why we don't see any panics.
This is still good to have however. So let's get this in.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link