Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FLYTE_INTERNAL_POD_NAME environment variable that holds the pod name #5616

Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7306683
Add environment variable for pod name
bgedik Aug 1, 2024
dd2957b
[flyteadmin] Refactor panic recovery into middleware (#5546)
Sovietaced Aug 1, 2024
d8e7491
Snowflake agent Doc (#5620)
Future-Outlier Aug 2, 2024
021c606
[flytepropeller][compiler] Error Handling when Type is not found (#5612)
Future-Outlier Aug 2, 2024
91d6d40
Fix nil pointer when task plugin load returns error (#5622)
Sovietaced Aug 2, 2024
eae4bf5
Log stack trace when refresh cache sync recovers from panic (#5623)
Sovietaced Aug 2, 2024
dcbc55a
use private-key (#5626)
Future-Outlier Aug 2, 2024
61cffe8
Explain how Agent Secret Works (#5625)
Future-Outlier Aug 2, 2024
2cf52ef
Fix typo in execution manager (#5619)
ddl-rliu Aug 2, 2024
a65a590
Amend Admin to use grpc message size (#5628)
wild-endeavor Aug 2, 2024
fe9fb67
document the process of setting ttl for a ray cluster (#5636)
pingsutw Aug 6, 2024
0514430
Add CustomHeaderMatcher to pass additional headers (#5563)
andrewwdye Aug 7, 2024
80c349d
Turn flyteidl and flytectl releases into manual gh workflows (#5635)
eapolinario Aug 8, 2024
ee724b1
docs: fix typo (#5643)
cratiu222 Aug 8, 2024
a9beb65
Use enable_deck=True in docs (#5645)
thomasjpfan Aug 8, 2024
392632d
Fix flyteidl release checkout all tags (#5646)
eapolinario Aug 8, 2024
ee4783e
Install pyarrow in sandbox functional tests (#5647)
eapolinario Aug 8, 2024
b21d674
docs: add documentation for configuring notifications in GCP (#5545)
desihsu Aug 9, 2024
aff319b
Correct "sucessfile" to "successfile" (#5652)
shengyu7697 Aug 12, 2024
4929522
Fix ordering for custom template values in cluster resource controlle…
katrogan Aug 12, 2024
5772d1f
Don't error when attempting to trigger schedules for inactive project…
katrogan Aug 12, 2024
2ddb4d2
fix tests
bgedik Aug 15, 2024
4e7a1c5
Merge branch 'master' of https://github.com/flyteorg/flyte into bugra…
bgedik Aug 15, 2024
1b24ca2
change to shorter names
bgedik Aug 20, 2024
ede7536
change to shorter names
bgedik Aug 20, 2024
7a14649
change to shorter names
bgedik Aug 20, 2024
783d75e
change to shorter names
bgedik Aug 20, 2024
c89950f
change to shorter names
bgedik Aug 20, 2024
63a1faa
Fix comment symbol
eapolinario Aug 20, 2024
52a6b77
fix one more test
bgedik Aug 20, 2024
81fcd81
Merge branch 'master' of https://github.com/flyteorg/flyte into bugra…
bgedik Aug 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,15 @@
Name: "FLYTE_INTERNAL_EXECUTION_DOMAIN",
Value: nodeExecutionID.Domain,
},
{
# FLYTE_INTERNAL_POD_NAME

Check failure on line 64 in flyteplugins/go/tasks/pluginmachinery/flytek8s/k8s_resource_adds.go

View workflow job for this annotation

GitHub Actions / compile

invalid character U+0023 '#'

Check failure on line 64 in flyteplugins/go/tasks/pluginmachinery/flytek8s/k8s_resource_adds.go

View workflow job for this annotation

GitHub Actions / compile

syntax error: unexpected newline in composite literal; possibly missing comma or }
Name: "_F_PN",
bgedik marked this conversation as resolved.
Show resolved Hide resolved
ValueFrom: &v1.EnvVarSource{
FieldRef: &v1.ObjectFieldSelector{
FieldPath: "metadata.name",
},
},
},

Check failure on line 71 in flyteplugins/go/tasks/pluginmachinery/flytek8s/k8s_resource_adds.go

View workflow job for this annotation

GitHub Actions / compile

syntax error: unexpected }, expected expression
{
Name: "FLYTE_ATTEMPT_NUMBER",
Value: attemptNumber,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ func TestGetExecutionEnvVars(t *testing.T) {
}{
{
"no-console-url",
12,
13,
"",
nil,
},
{
"with-console-url",
13,
14,
"scheme://host/path",
&v12.EnvVar{
Name: "FLYTE_EXECUTION_URL",
Expand All @@ -42,7 +42,7 @@ func TestGetExecutionEnvVars(t *testing.T) {
},
{
"with-console-url-ending-in-single-slash",
13,
14,
"scheme://host/path/",
&v12.EnvVar{
Name: "FLYTE_EXECUTION_URL",
Expand All @@ -51,7 +51,7 @@ func TestGetExecutionEnvVars(t *testing.T) {
},
{
"with-console-url-ending-in-multiple-slashes",
13,
14,
"scheme://host/path////",
&v12.EnvVar{
Name: "FLYTE_EXECUTION_URL",
Expand All @@ -63,7 +63,7 @@ func TestGetExecutionEnvVars(t *testing.T) {
envVars := GetExecutionEnvVars(mock, tt.consoleURL)
assert.Len(t, envVars, tt.expectedEnvVars)
if tt.expectedEnvVar != nil {
assert.True(t, proto.Equal(&envVars[4], tt.expectedEnvVar))
assert.True(t, proto.Equal(&envVars[5], tt.expectedEnvVar))
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions flyteplugins/go/tasks/plugins/k8s/spark/spark_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ func TestBuildResourcePodTemplate(t *testing.T) {
assert.Equal(t, defaultConfig.DefaultEnvVars["foo"], findEnvVarByName(sparkApp.Spec.Driver.Env, "foo").Value)
assert.Equal(t, defaultConfig.DefaultEnvVars["fooEnv"], findEnvVarByName(sparkApp.Spec.Driver.Env, "fooEnv").Value)
assert.Equal(t, findEnvVarByName(dummyEnvVarsWithSecretRef, "SECRET"), findEnvVarByName(sparkApp.Spec.Driver.Env, "SECRET"))
assert.Equal(t, 9, len(sparkApp.Spec.Driver.Env))
assert.Equal(t, 10, len(sparkApp.Spec.Driver.Env))
bgedik marked this conversation as resolved.
Show resolved Hide resolved
assert.Equal(t, testImage, *sparkApp.Spec.Driver.Image)
assert.Equal(t, flytek8s.GetServiceAccountNameFromTaskExecutionMetadata(taskCtx.TaskExecutionMetadata()), *sparkApp.Spec.Driver.ServiceAccount)
assert.Equal(t, defaultConfig.DefaultPodSecurityContext, sparkApp.Spec.Driver.SecurityContenxt)
Expand Down Expand Up @@ -890,7 +890,7 @@ func TestBuildResourcePodTemplate(t *testing.T) {
assert.Equal(t, defaultConfig.DefaultEnvVars["foo"], findEnvVarByName(sparkApp.Spec.Executor.Env, "foo").Value)
assert.Equal(t, defaultConfig.DefaultEnvVars["fooEnv"], findEnvVarByName(sparkApp.Spec.Executor.Env, "fooEnv").Value)
assert.Equal(t, findEnvVarByName(dummyEnvVarsWithSecretRef, "SECRET"), findEnvVarByName(sparkApp.Spec.Executor.Env, "SECRET"))
assert.Equal(t, 9, len(sparkApp.Spec.Executor.Env))
assert.Equal(t, 10, len(sparkApp.Spec.Executor.Env))
assert.Equal(t, testImage, *sparkApp.Spec.Executor.Image)
assert.Equal(t, defaultConfig.DefaultPodSecurityContext, sparkApp.Spec.Executor.SecurityContenxt)
assert.Equal(t, defaultConfig.DefaultPodDNSConfig, sparkApp.Spec.Executor.DNSConfig)
Expand Down
Loading