-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custominfo to agents #5604
Add custominfo to agents #5604
Conversation
af15a6e
to
252bac0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5604 +/- ##
===========================================
- Coverage 60.92% 36.17% -24.76%
===========================================
Files 796 1302 +506
Lines 51689 109494 +57805
===========================================
+ Hits 31494 39607 +8113
- Misses 17288 65749 +48461
- Partials 2907 4138 +1231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Could we add a small test here?
Thanks for the pointer, done! afd264f |
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
503cbd3
to
afd264f
Compare
Signed-off-by: ddl-rliu <[email protected]> Signed-off-by: pmahindrakar-oss <[email protected]>
Signed-off-by: ddl-rliu <[email protected]> Signed-off-by: Bugra Gedik <[email protected]>
Tracking issue
#5603
Why are the changes needed?
Agents may use the Resource object to pass some data back to flyte, but the
CustomInfo
field is not being passed on in Flyte.What changes were proposed in this pull request?
Pass on the
CustomInfo
field in Flyte when receiving a response from agents.How was this patch tested?
Check that
custom_info
is correctly passed when callingListTaskExecutions
:Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytekit#2426
Docs link