Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify single task retry strategy check #5584

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

eapolinario
Copy link
Contributor

Why are the changes needed?

Make the intent of single task retry check more clear

What changes were proposed in this pull request?

Remove unnecessary checks. Since core.RetryStrategy is a protobuf message we assume that calls to Get* are guarded against nil.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.91%. Comparing base (a07753e) to head (f122672).
Report is 117 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5584   +/-   ##
=======================================
  Coverage   35.90%   35.91%           
=======================================
  Files        1301     1301           
  Lines      109403   109401    -2     
=======================================
+ Hits        39282    39286    +4     
+ Misses      66024    66018    -6     
  Partials     4097     4097           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 53.73% <100.00%> (+0.02%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (ø)
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.75% <ø> (ø)
unittests-flytestdlib 55.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@katrogan katrogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@eapolinario eapolinario merged commit 1f26055 into master Jul 24, 2024
50 checks passed
@eapolinario eapolinario deleted the simplify-nil-check branch July 24, 2024 15:04
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants