Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted mockery-v2 on ExecutionContext #5562

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

hamersaw
Copy link
Contributor

Why are the changes needed?

This PR updated the mockery command to only produce mocks for the ExecutionContext interface. This blocks updating any other construct.

What changes were proposed in this pull request?

Revert the mockery generate command.

How was this patch tested?

Unit tests.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Sorry, something went wrong.

Signed-off-by: Daniel Rammer <daniel@union.ai>
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (c1563d7) to head (2688a4a).
Report is 115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5562      +/-   ##
==========================================
- Coverage   60.98%   60.96%   -0.02%     
==========================================
  Files         796      796              
  Lines       51647    51647              
==========================================
- Hits        31497    31489       -8     
- Misses      17250    17257       +7     
- Partials     2900     2901       +1     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.69% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.44% <ø> (ø)
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.42% <ø> (ø)
unittests-flytestdlib 65.60% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamersaw hamersaw requested a review from pvditt July 16, 2024 16:46
@hamersaw hamersaw merged commit 220d594 into master Jul 16, 2024
49 of 50 checks passed
@hamersaw hamersaw deleted the housekeeping/revert-mockery-v2-propeller branch July 16, 2024 16:48
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Vladyslav Libov <vladyslav.libov@d-fine.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants