Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with helm chart release process #5560

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented Jul 15, 2024

I am currently attempting to get our fork of Flyte to push helm charts to our artifact store and I ran into some issues. This pull request fixes two issues.

  1. Updates the script to find/replace the version of the flyteagent helm chart such that flyte-core is able to find a matching version of the relative helm chart reference when doing helm dependency update. This should publish an actual updated version of the flyteagent helm chart instead of overwriting it (and potentially breaking peoples deployments) : https://artifacthub.io/packages/helm/flyte/flyteagent
  2. Updates the script to patch each respective README instead of continuously overwriting the flyte-core README. This should fix the broken README that is currently live for flyte-core: https://artifacthub.io/packages/helm/flyte/flyte-core

@Sovietaced Sovietaced marked this pull request as ready for review July 15, 2024 21:50
@Sovietaced Sovietaced changed the title Fix script to prepare helm artifacts during release Fix issues with helm chart release process Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.97%. Comparing base (b7e6959) to head (6fbc922).
Report is 119 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5560      +/-   ##
==========================================
- Coverage   60.98%   60.97%   -0.01%     
==========================================
  Files         796      796              
  Lines       51647    51647              
==========================================
- Hits        31498    31494       -4     
- Misses      17249    17253       +4     
  Partials     2900     2900              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.69% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.49% <ø> (+0.05%) ⬆️
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.42% <ø> (ø)
unittests-flytestdlib 65.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 94af58f into flyteorg:master Jul 16, 2024
50 checks passed
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants