Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pryce/doc 434 clarify how code is pushed into a given image during pyflyte #5548

Conversation

pryce-turner
Copy link
Contributor

@pryce-turner pryce-turner commented Jul 9, 2024

  1. Updated docs regarding where code is pushed during the different register and run commands
  2. Removed experimental tag from arraynode

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.97%. Comparing base (b7e6959) to head (6cd6974).
Report is 113 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5548      +/-   ##
==========================================
- Coverage   60.98%   60.97%   -0.02%     
==========================================
  Files         796      796              
  Lines       51647    51647              
==========================================
- Hits        31498    31491       -7     
- Misses      17249    17256       +7     
  Partials     2900     2900              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.69% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.44% <ø> (ø)
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.42% <ø> (ø)
unittests-flytestdlib 65.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: pryce-turner <[email protected]>
Signed-off-by: pryce-turner <[email protected]>
@pryce-turner pryce-turner merged commit b171b51 into master Jul 10, 2024
49 of 50 checks passed
@pryce-turner pryce-turner deleted the pryce/doc-434-clarify-how-code-is-pushed-into-a-given-image-during-pyflyte branch July 10, 2024 17:18
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
…flyte (flyteorg#5548)

* Removed experimental designation for array node

Signed-off-by: pryce-turner <[email protected]>

* Added .flyteignore as an ignore option

Signed-off-by: pryce-turner <[email protected]>

* Added notes on where registered workflows land

Signed-off-by: pryce-turner <[email protected]>

* spelling and formatting

Signed-off-by: pryce-turner <[email protected]>

* more formatting

Signed-off-by: pryce-turner <[email protected]>

---------

Signed-off-by: pryce-turner <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants