Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update runllm widget configuration #5530

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Jul 1, 2024

Why are the changes needed?

This PR updates the RunLLM widget configuration to use our new widget.runllm.com url.

How was this patch tested?

Tested by adding URL to the docs site and making sure that the docs widget renders.

Check all the applicable boxes

If you would like to test in a staging domain, please let me know so I can add to our ReCAPTCHA validation.

This change is really just updating where you get the latest bits of the runllm widget from.

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@agiron123 agiron123 force-pushed the runllm-widget-url-update branch from d13faf1 to 7eae6f6 Compare July 2, 2024 20:57
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (5b0d787) to head (7eae6f6).
Report is 117 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5530      +/-   ##
==========================================
- Coverage   60.97%   60.92%   -0.05%     
==========================================
  Files         794      796       +2     
  Lines       51488    51689     +201     
==========================================
+ Hits        31397    31494      +97     
- Misses      17199    17288      +89     
- Partials     2892     2907      +15     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.73% <ø> (+0.04%) ⬆️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.41% <ø> (-0.63%) ⬇️
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.25% <ø> (-0.04%) ⬇️
unittests-flytestdlib 65.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 5c33464 into flyteorg:master Jul 4, 2024
49 of 50 checks passed
@agiron123 agiron123 deleted the runllm-widget-url-update branch July 9, 2024 18:09
vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Andre Giron <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants