Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-value execution tags #5453

Merged
merged 17 commits into from
Jun 8, 2024

nit

5684388
Select commit
Loading
Failed to load commit list.
Merged

Key-value execution tags #5453

nit
5684388
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 7, 2024 in 1s

60.99% (-0.09%) compared to 25c3596

View this Pull Request on Codecov

60.99% (-0.09%) compared to 25c3596

Details

Codecov Report

Attention: Patch coverage is 24.32432% with 84 lines in your changes missing coverage. Please review.

Project coverage is 60.99%. Comparing base (25c3596) to head (5684388).

Files Patch % Lines
flyteadmin/pkg/repositories/config/migrations.go 0.00% 32 Missing ⚠️
...teadmin/pkg/repositories/transformers/execution.go 0.00% 24 Missing ⚠️
flyteadmin/pkg/manager/impl/execution_manager.go 50.00% 17 Missing and 1 partial ⚠️
...eadmin/pkg/repositories/gormimpl/execution_repo.go 53.84% 3 Missing and 3 partials ⚠️
flyteadmin/pkg/common/filters.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5453      +/-   ##
==========================================
- Coverage   61.07%   60.99%   -0.09%     
==========================================
  Files         793      793              
  Lines       51226    51295      +69     
==========================================
- Hits        31288    31287       -1     
- Misses      17062    17128      +66     
- Partials     2876     2880       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov