Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flyteconsole url to FlyteWorkflow CRD #5449

Merged
merged 14 commits into from
Jun 14, 2024

Include review feedback

501d3ee
Select commit
Loading
Failed to load commit list.
Merged

Add flyteconsole url to FlyteWorkflow CRD #5449

Include review feedback
501d3ee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jun 13, 2024 in 0s

76.66% of diff hit (target 61.93%)

View this Pull Request on Codecov

76.66% of diff hit (target 61.93%)

Annotations

Check warning on line 59 in flyteadmin/pkg/workflowengine/impl/k8s_executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/workflowengine/impl/k8s_executor.go#L59 

Added line #L59 was not covered by tests

Check warning on line 321 in flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L321 

Added line #L321 was not covered by tests

Check warning on line 329 in flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L328-L329 

Added lines #L328 - L329 were not covered by tests

Check warning on line 108 in flytepropeller/pkg/apis/flyteworkflow/v1alpha1/workflow.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/apis/flyteworkflow/v1alpha1/workflow.go#L108 

Added line #L108 was not covered by tests
View more details on Codecov