Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to get domain #5443

Merged
merged 11 commits into from
Jun 20, 2024

regenerate flyteidl.d.ts

13551b4
Select commit
Loading
Failed to load commit list.
Merged

Add API to get domain #5443

regenerate flyteidl.d.ts
13551b4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 20, 2024 in 0s

61.34% (+0.32%) compared to 297cdf8

View this Pull Request on Codecov

61.34% (+0.32%) compared to 297cdf8

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.34%. Comparing base (297cdf8) to head (13551b4).

Files Patch % Lines
flyteadmin/pkg/rpc/adminservice/project.go 0.00% 10 Missing ⚠️
flytectl/pkg/ext/domain_fetcher.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5443      +/-   ##
==========================================
+ Coverage   61.01%   61.34%   +0.32%     
==========================================
  Files         793      791       -2     
  Lines       51419    51040     -379     
==========================================
- Hits        31372    31309      -63     
+ Misses      17155    16851     -304     
+ Partials     2892     2880      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.