Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos using codespell CI job #5418

Merged
merged 3 commits into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .codespellrc

This file was deleted.

11 changes: 11 additions & 0 deletions .github/codespell-ignored-words
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
crate
eapolinario marked this conversation as resolved.
Show resolved Hide resolved
lightyear
fo
notin
ThirdParty
bootup
te
nd
querys
ser
updAt
4 changes: 2 additions & 2 deletions .github/workflows/codespell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ jobs:
- name: Codespell
uses: codespell-project/actions-codespell@v2
with:
skip: "*.pb,monodocs-environment.lock.yaml"
ignore_words_list: crate,lightyear,fo
skip: "*.pb,monodocs-environment.lock.yaml,.git,*.pdf,*.svg,go.sum,go.mod,*requirements.txt,gen"
ignore_words_file: .github/codespell-ignored-words
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ lint-helm-charts:
# This pressuposes that you have act installed
act pull_request -W .github/workflows/validate-helm-charts.yaml --container-architecture linux/amd64 -e charts/event.json

.PHONY: spellcheck
spellcheck:
act pull_request --container-architecture linux/amd64 -W .github/workflows/codespell.yml

.PHONY: clean
clean: ## Remove the HTML files related to the Flyteconsole and Makefile
rm -rf cmd/single/dist .tmp_build
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ otelutils.JaegerConfig
endpoint (string)
""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""

Endpoint for the jaeger telemtry trace ingestor
Endpoint for the jaeger telemetry trace ingestor

**Default Value**:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2557,7 +2557,7 @@ otelutils.JaegerConfig
endpoint (string)
""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""

Endpoint for the jaeger telemtry trace ingestor
Endpoint for the jaeger telemetry trace ingestor

**Default Value**:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,7 @@ otelutils.JaegerConfig
endpoint (string)
""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""

Endpoint for the jaeger telemtry trace ingestor
Endpoint for the jaeger telemetry trace ingestor

**Default Value**:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2557,7 +2557,7 @@ otelutils.JaegerConfig
endpoint (string)
""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""

Endpoint for the jaeger telemtry trace ingestor
Endpoint for the jaeger telemetry trace ingestor

**Default Value**:

Expand Down
4 changes: 2 additions & 2 deletions flyteadmin/scheduler/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// The above actions are exposed through launchplan activation/deactivation api's and do not have separate controls.
// Whenever a launchplan with a schedule is activated, a new schedule entry is created in the datastore
// On deactivation the created scheduled and launchplan is deactivated through a flag
// Atmost one launchplan is active at any moment across its various versions and same semantics apply for the
// At most one launchplan is active at any moment across its various versions and same semantics apply for the
// schedules as well.
// 2] Scheduler
// This component is a singleton and has its source in the current folder and is responsible for reading the schedules
Expand Down Expand Up @@ -78,7 +78,7 @@
// by the admin. i.e admin could execute the schedules in this order T2, T1. This is rare case though
//
// c) Case when the scheduler goes down then once it comes back up it will run catch up on all the schedules using
// the last snapshoted timestamp to time.Now()
// the last snapshotted timestamp to time.Now()
//
// d) Case when the snapshoter fails to record the last execution at T2 but has recorded at T1, where T1 < T2 ,
// then new schedules would be created from T1 -> time.Now() during catchup and the idempotency aspect of the admin
Expand Down
2 changes: 1 addition & 1 deletion flyteadmin/scheduler/snapshoter/doc.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Package snapshoter
// This package provides the ability to snapshot all the schedules in the scheduler job store and persist them in the DB
// in GOB binary format. Also it provides ability to bootstrap the scheduler from this snapshot so that the scheduler
// can run catchup for all the schedules from the snapshoted time.
// can run catchup for all the schedules from the snapshotted time.
package snapshoter
2 changes: 1 addition & 1 deletion flytectl/cmd/compile/compile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func TestCompilePackage(t *testing.T) {

// invalid workflow, types do not match
err = compileFromPackage("testdata/bad-workflow-package.tgz")
assert.NotNil(t, err, "compilin an invalid workflow returns no error")
assert.NotNil(t, err, "compiling an invalid workflow returns no error")

// testing badly serialized task
err = compileFromPackage("testdata/invalidtask.tgz")
Expand Down
2 changes: 1 addition & 1 deletion flytectl/proposal/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ Support

## Install all examples

Today Flytesnacks houses a few examples for Flyte usage in python. When a user wants to get started with Flyte quickly, it would be preferable that all Flytesnacks examples are serialized and stored as artifacts in flytesnacks for every checkin. This can be done for python flytekit using `pyflyte serialize` command. Once they are posted as serialized blobs, flytectl could easily retrieve them and register them in a specific project as desired by the user.
Today Flytesnacks houses a few examples for Flyte usage in python. When a user wants to get started with Flyte quickly, it would be preferable that all Flytesnacks examples are serialized and stored as artifacts in flytesnacks for every commit to master. This can be done for python flytekit using `pyflyte serialize` command. Once they are posted as serialized blobs, flytectl could easily retrieve them and register them in a specific project as desired by the user.

```bash
$ flytectl examples register-all [cookbook|plugins|--custom-path=remote-path] [--semver semantic-version-of-flytesnacks-examples] --target-project --target-domain
Expand Down
67 changes: 67 additions & 0 deletions flyteidl/clients/go/assets/admin.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion flytestdlib/otelutils/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type FileConfig struct {
}

type JaegerConfig struct {
Endpoint string `json:"endpoint" pflag:",Endpoint for the jaeger telemtry trace ingestor"`
Endpoint string `json:"endpoint" pflag:",Endpoint for the jaeger telemetry trace ingestor"`
}

func GetConfig() *Config {
Expand Down
2 changes: 1 addition & 1 deletion flytestdlib/otelutils/config_flags.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading