Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/docker/docker from 20.10.7+incompatible to 24.0.9+incompatible in /flytectl #5363

Merged
merged 1 commit into from
May 15, 2024

Conversation

ddl-ebrown
Copy link
Contributor

@ddl-ebrown ddl-ebrown commented May 14, 2024

Updated version of #5305 that gets the update compiing

Bumps github.com/docker/docker from 20.10.7+incompatible to 24.0.9+incompatible.


updated-dependencies:

  • dependency-name: github.com/docker/docker
    dependency-type: direct:production
    ...

Signed-off-by: dependabot[bot] [email protected]## Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.7+incompatible to 24.0.9+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.7...v24.0.9)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
...

- Some types changed packages and some structs had new fields added.
  Move those around regenerate mocks with `make generate`

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: ddl-ebrown <[email protected]>
@ddl-ebrown ddl-ebrown changed the title Bump github.com/docker/docker in /flytectl Bump github.com/docker/docker from 20.10.7+incompatible to 24.0.9+incompatible in /flytectl May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.10%. Comparing base (aa1f211) to head (74d34ea).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5363   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files         794      794           
  Lines       51213    51215    +2     
=======================================
+ Hits        31295    31297    +2     
  Misses      17037    17037           
  Partials     2881     2881           
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <100.00%> (+0.01%) ⬆️
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor

This is awesome, @ddl-ebrown, thank you!

@eapolinario eapolinario merged commit 7b82397 into flyteorg:master May 15, 2024
48 checks passed
@ddl-ebrown ddl-ebrown deleted the update-flytectl-docker branch May 15, 2024 01:48
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.7+incompatible to 24.0.9+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.7...v24.0.9)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
...

- Some types changed packages and some structs had new fields added.
  Move those around regenerate mocks with `make generate`

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: ddl-ebrown <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
troychiu pushed a commit that referenced this pull request Jul 8, 2024
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.7+incompatible to 24.0.9+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v20.10.7...v24.0.9)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
...

- Some types changed packages and some structs had new fields added.
  Move those around regenerate mocks with `make generate`

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: ddl-ebrown <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants