Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup flytectl #5309

Merged
merged 12 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
- flyteadmin
# TODO(monorepo): Enable lint flytecopilot
# - flytecopilot
- flytectl
- flyteidl
- flyteplugins
- flytepropeller
Expand All @@ -53,6 +54,7 @@ jobs:
- datacatalog
- flyteadmin
- flytecopilot
- flytectl
- flyteplugins
- flytepropeller
- flytestdlib
Expand All @@ -74,7 +76,7 @@ jobs:
name: Docker Build Images
uses: ./.github/workflows/component_docker_build.yml
with:
component: ${{ matrix.component }}
component: ${{ matrix.component }}

# TODO(monorepo): these tests are broken. They never test an actual change.
# endtoend:
Expand Down Expand Up @@ -113,6 +115,7 @@ jobs:
- datacatalog
- flyteadmin
- flytecopilot
- flytectl
- flytepropeller
uses: ./.github/workflows/go_generate.yml
with:
Expand Down
6 changes: 6 additions & 0 deletions flytectl/.golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,9 @@ linters:
- unparam
- unused
- varcheck
linters-settings:
gci:
skip-generated: true
issues:
exclude:
- copylocks
2 changes: 0 additions & 2 deletions flytectl/CODE_OF_CONDUCT.md

This file was deleted.

11 changes: 9 additions & 2 deletions flytectl/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
export REPOSITORY=flytectl
include boilerplate/flyte/golang_test_targets/Makefile
include boilerplate/flyte/precommit/Makefile
export REPO_ROOT=..
include ../boilerplate/flyte/docker_build/Makefile
include ../boilerplate/flyte/golang_test_targets/Makefile
include ../boilerplate/flyte/end2end/Makefile

GIT_VERSION := $(shell git describe --always --tags)
GIT_HASH := $(shell git rev-parse --short HEAD)
Expand Down Expand Up @@ -38,3 +40,8 @@ test_unit_without_flag:
cat coverage.temp.txt | grep -v "_flags.go" > coverage.txt
rm coverage.temp.txt
curl -s https://codecov.io/bash > codecov_bash.sh && bash codecov_bash.sh

# TODO - Add the -race flag back
.PHONY: test_unit
test_unit:
go test -cover ./...
10 changes: 5 additions & 5 deletions flytectl/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
</html>

[![Docs](https://readthedocs.org/projects/flytectl/badge/?version=latest&style=plastic)](https://flytectl.rtfd.io)
[![Current Release](https://img.shields.io/github/release/flyteorg/flytectl.svg)](https://github.com/flyteorg/flytectl/releases/latest)
![Master](https://github.com/flyteorg/flytectl/workflows/Master/badge.svg)
[![GoDoc](https://godoc.org/github.com/flyteorg/flytectl?status.svg)](https://pkg.go.dev/mod/github.com/flyteorg/flytectl)
[![Current Release](https://img.shields.io/github/release/flyteorg/flyte/flytectl.svg)](https://github.com/flyteorg/flytectl/releases/latest)
![Master](https://github.com/flyteorg/flyte/flytectl/workflows/Master/badge.svg)
[![GoDoc](https://godoc.org/github.com/flyteorg/flyte/flytectl?status.svg)](https://pkg.go.dev/mod/github.com/flyteorg/flytectl)
[![License](https://img.shields.io/badge/LICENSE-Apache2.0-ff69b4.svg)](http://www.apache.org/licenses/LICENSE-2.0.html)
[![CodeCoverage](https://img.shields.io/codecov/c/github/flyteorg/flytectl.svg)](https://codecov.io/gh/flyteorg/flytectl)
[![Go Report Card](https://goreportcard.com/badge/github.com/flyteorg/flytectl)](https://goreportcard.com/report/github.com/flyteorg/flytectl)
[![CodeCoverage](https://img.shields.io/codecov/c/github/flyteorg/flyte/flytectl.svg)](https://codecov.io/gh/flyteorg/flytectl)
[![Go Report Card](https://goreportcard.com/badge/github.com/flyteorg/flyte/flytectl)](https://goreportcard.com/report/github.com/flyteorg/flytectl)
![Commit activity](https://img.shields.io/github/commit-activity/w/lyft/flytectl.svg?style=plastic)
![Commit since last release](https://img.shields.io/github/commits-since/lyft/flytectl/latest.svg?style=plastic)
[![Slack](https://img.shields.io/badge/slack-join_chat-white.svg?logo=slack&style=social)](https://slack.flyte.org)
Expand Down
2 changes: 0 additions & 2 deletions flytectl/boilerplate/flyte/code_of_conduct/CODE_OF_CONDUCT.md

This file was deleted.

2 changes: 0 additions & 2 deletions flytectl/boilerplate/flyte/code_of_conduct/README.rst

This file was deleted.

12 changes: 0 additions & 12 deletions flytectl/boilerplate/flyte/code_of_conduct/update.sh

This file was deleted.

247 changes: 0 additions & 247 deletions flytectl/boilerplate/flyte/golang_support_tools/go.mod

This file was deleted.

Loading
Loading