Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution phase #5127

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Fix execution phase #5127

merged 5 commits into from
Mar 28, 2024

Conversation

troychiu
Copy link
Member

@troychiu troychiu commented Mar 27, 2024

Why are the changes needed?

The execution phase should be FAILED because of the error in input pass to CreateExecutionModel(). However, we only update the phase in closure but not in execution.phase.

As a follow up, we don't even need Phase in the CreateExecutionModelInput

What changes were proposed in this pull request?

  1. Fix the bug
  2. Add assertion in test.
  3. Clean up redundant phase in CreateExecutionModelInput{

Signed-off-by: troychiu <y.troychiu@gmail.com>
Signed-off-by: troychiu <y.troychiu@gmail.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.01%. Comparing base (c81133b) to head (ec6d613).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5127      +/-   ##
==========================================
- Coverage   59.03%   59.01%   -0.02%     
==========================================
  Files         645      645              
  Lines       55726    55720       -6     
==========================================
- Hits        32896    32884      -12     
- Misses      20233    20239       +6     
  Partials     2597     2597              
Flag Coverage Δ
unittests 59.01% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@troychiu troychiu requested a review from katrogan March 27, 2024 22:06
Signed-off-by: troychiu <y.troychiu@gmail.com>
fix test
Signed-off-by: troychiu <y.troychiu@gmail.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 28, 2024
katrogan
katrogan previously approved these changes Mar 28, 2024
flyteadmin/pkg/repositories/transformers/execution.go Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 28, 2024
Signed-off-by: troychiu <y.troychiu@gmail.com>
@troychiu troychiu merged commit 920fd67 into master Mar 28, 2024
47 of 48 checks passed
@troychiu troychiu deleted the fix-execution-phase branch March 28, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants