-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix execution phase #5127
Merged
Merged
Fix execution phase #5127
+7
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: troychiu <y.troychiu@gmail.com>
Signed-off-by: troychiu <y.troychiu@gmail.com>
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
bug
Something isn't working
housekeeping
Issues that help maintain flyte and keep it tech-debt free
labels
Mar 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5127 +/- ##
==========================================
- Coverage 59.03% 59.01% -0.02%
==========================================
Files 645 645
Lines 55726 55720 -6
==========================================
- Hits 32896 32884 -12
- Misses 20233 20239 +6
Partials 2597 2597
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
katrogan
reviewed
Mar 27, 2024
Signed-off-by: troychiu <y.troychiu@gmail.com>
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Mar 28, 2024
katrogan
previously approved these changes
Mar 28, 2024
Signed-off-by: troychiu <y.troychiu@gmail.com>
katrogan
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
housekeeping
Issues that help maintain flyte and keep it tech-debt free
lgtm
This PR has been approved by a maintainer
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The execution phase should be FAILED because of the error in input pass to
CreateExecutionModel()
. However, we only update the phase in closure but not inexecution.phase
.As a follow up, we don't even need
Phase
in theCreateExecutionModelInput
What changes were proposed in this pull request?
CreateExecutionModelInput{