Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in "Mapping Python to Flyte types" table #5122

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Mar 26, 2024

Why are the changes needed?

Fixes broken link in this table: https://docs.flyte.org/en/latest/user_guide/data_types_and_io/index.html#mapping-python-to-flyte-types

What changes were proposed in this pull request?

Remove bold styling to fix link.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

TK

Signed-off-by: nikki everett <[email protected]>
@neverett neverett self-assigned this Mar 26, 2024
@neverett neverett requested a review from ppiegaze as a code owner March 26, 2024 22:37
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.01%. Comparing base (c21ded6) to head (5c29c76).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5122      +/-   ##
==========================================
+ Coverage   58.99%   59.01%   +0.02%     
==========================================
  Files         645      645              
  Lines       55672    55672              
==========================================
+ Hits        32843    32855      +12     
+ Misses      20233    20223      -10     
+ Partials     2596     2594       -2     
Flag Coverage Δ
unittests 59.01% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 26, 2024
@eapolinario eapolinario merged commit 78a690f into master Mar 26, 2024
48 checks passed
@eapolinario eapolinario deleted the nikki/fix-link branch March 26, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants