Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/grpc and otelgrpc #5121

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

https://github.com/flyteorg/flyte/security/dependabot/156 and https://github.com/flyteorg/flyte/security/dependabot/135 are two high severity dependabot alerts.

What changes were proposed in this pull request?

Bump the version of a google.golang.org/grpc and go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. security Issues related to Security improvements labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (cb6384a) to head (aa0d701).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5121      +/-   ##
==========================================
+ Coverage   58.49%   58.99%   +0.49%     
==========================================
  Files         627      645      +18     
  Lines       54155    55672    +1517     
==========================================
+ Hits        31680    32843    +1163     
- Misses      19942    20233     +291     
- Partials     2533     2596      +63     
Flag Coverage Δ
unittests 58.99% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 9bdf597 into master Mar 26, 2024
48 checks passed
@eapolinario eapolinario deleted the dependabot-135--gRPC-Go-HTTP2 branch March 26, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Issues related to Security improvements size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant