Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary step and fix numbering in code examples #5104

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

https://github.com/flyteorg/flyte/pull/4509/files removed the unnecessary step, but during the monodocs work we ended up bringing that step back.

What changes were proposed in this pull request?

Remove the need to use sed to replace the contents of the $HOME env var in flyte-single-binary-local.yaml.

I also added a single space between the word Step and the number to increase readability.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Mar 25, 2024
@eapolinario eapolinario enabled auto-merge (squash) March 25, 2024 22:34
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.00%. Comparing base (cb6384a) to head (2390a48).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5104      +/-   ##
==========================================
+ Coverage   58.49%   59.00%   +0.50%     
==========================================
  Files         627      645      +18     
  Lines       54155    55670    +1515     
==========================================
+ Hits        31680    32850    +1170     
- Misses      19942    20224     +282     
- Partials     2533     2596      +63     
Flag Coverage Δ
unittests 59.00% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit d68047a into master Mar 26, 2024
48 checks passed
@eapolinario eapolinario deleted the eapolinario-patch-2 branch March 26, 2024 00:50
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 26, 2024
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants