Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagemaker agent backend setup documentation #5064

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Conversation

samhita-alla
Copy link
Contributor

@samhita-alla samhita-alla commented Mar 15, 2024

Tracking issue

Fixes #4079

Why are the changes needed?

These changes are required to add the additional library that the sagemaker agent requires while building docs and to document the backend setup config.

What changes were proposed in this pull request?

Documentation updates.

How was this patch tested?

Built the documentation locally.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@samhita-alla samhita-alla changed the title sagemaker agent backend setup doc sagemaker agent backend setup documentation Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.98%. Comparing base (3100c12) to head (f7625c1).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5064      +/-   ##
==========================================
+ Coverage   58.97%   58.98%   +0.01%     
==========================================
  Files         645      645              
  Lines       55578    55648      +70     
==========================================
+ Hits        32778    32825      +47     
- Misses      20207    20228      +21     
- Partials     2593     2595       +2     
Flag Coverage Δ
unittests 58.98% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 18, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 21, 2024
@samhita-alla samhita-alla merged commit c13d601 into master Mar 22, 2024
48 checks passed
@samhita-alla samhita-alla deleted the sagemaker-agent branch March 22, 2024 06:17
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* sagemaker agent backend setup doc

Signed-off-by: Samhita Alla <[email protected]>

* update requirement and remove debugging code

Signed-off-by: Samhita Alla <[email protected]>

* add python-kubernetes

Signed-off-by: Samhita Alla <[email protected]>

* incorporate suggestions by Nikki

Signed-off-by: Samhita Alla <[email protected]>

---------

Signed-off-by: Samhita Alla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Sagemaker Agent
2 participants