Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Monodocs build #5000

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Fix Monodocs build #5000

merged 5 commits into from
Mar 4, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 4, 2024

Fix Monodocs build errors in CI

Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Mar 4, 2024
pingsutw added 2 commits March 4, 2024 09:41
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
katrogan
katrogan previously approved these changes Mar 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.97%. Comparing base (a946070) to head (6f67bb5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5000      +/-   ##
==========================================
- Coverage   58.97%   58.97%   -0.01%     
==========================================
  Files         645      645              
  Lines       55561    55562       +1     
==========================================
  Hits        32767    32767              
- Misses      20199    20200       +1     
  Partials     2595     2595              
Flag Coverage Δ
unittests 58.97% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <[email protected]>
eapolinario
eapolinario previously approved these changes Mar 4, 2024
Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Signed-off-by: Kevin Su <[email protected]>
@eapolinario eapolinario enabled auto-merge (squash) March 4, 2024 19:08
@eapolinario eapolinario disabled auto-merge March 4, 2024 19:08
@eapolinario
Copy link
Contributor

docs/readthedocs.org:flyte is failing with what seems like OOM? https://readthedocs.org/projects/flyte/builds/23642379/

@pingsutw pingsutw merged commit 4a95abf into master Mar 4, 2024
47 of 49 checks passed
@pingsutw pingsutw deleted the fix-monodoc-build branch March 4, 2024 22:16
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants