Fix separateGrpcIngress flag not working in flyte-binary helm chart

[lowc1012]

Tracking issue

Closes #4870

Why are the changes needed?

We added .Values.ingress.separateGrpcIngress in flyte-core chart, but not in flyte-binary.

What changes were proposed in this pull request?

1. add ingress.separateGrpcIngress (false by default) in values.yaml for flyte-binary chart
2. separate the ingress and service resources for grpc & http according this flag

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

[lowc1012]

Hi @eapolinario
Can you help review this one at your convenience time? Thank you

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.02%. Comparing base (78a690f) to head (59626d1).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4946      +/-   ##
==========================================
+ Coverage   59.00%   59.02%   +0.02%     
==========================================
  Files         645      645              
  Lines       55672    55726      +54     
==========================================
+ Hits        32847    32895      +48     
- Misses      20230    20234       +4     
- Partials     2595     2597       +2     

Flag	Coverage Δ
unittests	59.02% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidmirror-ops]

I just tried this PR on a local K8s cluster with NGINX.

Regardless of setting ingress.separateGrpcIngress to false it still creates two Ingress resources.

 k get ingress -n flyte                                                      
NAME                     CLASS   HOSTS                ADDRESS   PORTS   AGE
flyte-binary-test-http   nginx   flyte.mydomain.com             80      6s
flyte-binary-test-grpc   nginx   flyte.mydomain.com             80      6s

What other flag should be set?

[lowc1012]

@davidmirror-ops
hmm... no other flag. here is my test screenshot

[davidmirror-ops]

Thank you!

[davidmirror-ops]

@neverett any idea why the docs test fails here with a bunch of imports?

[eapolinario]

We missed a * here. Fix is https://github.com/flyteorg/flyte/pull/5185/files.