Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async agent example #4906

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

pingsutw
Copy link
Member

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 15, 2024
@pingsutw pingsutw changed the base branch from master to docs/agents-updates February 15, 2024 23:00
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5cd118) 58.92% compared to head (338899f) 58.98%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           docs/agents-updates    #4906      +/-   ##
=======================================================
+ Coverage                58.92%   58.98%   +0.06%     
=======================================================
  Files                      645      644       -1     
  Lines                    55380    55146     -234     
=======================================================
- Hits                     32632    32529     -103     
+ Misses                   20165    20043     -122     
+ Partials                  2583     2574       -9     
Flag Coverage Δ
unittests 58.98% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 15, 2024
```

For an example implementation, see the [BigQuery Agent](https://github.com/flyteorg/flytekit/blob/9977aac26242ebbede8e00d476c2fbc59ac5487a/plugins/flytekit-bigquery/flytekitplugins/bigquery/agent.py#L35).

## Sync agent interface specification
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neverett, I'll add it back in the separate PR because some sync agent APIs are still under discussion.

@pingsutw pingsutw changed the title Add sync agent example Update async agent example Feb 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 16, 2024
@neverett neverett merged commit 30e0354 into docs/agents-updates Feb 16, 2024
46 of 48 checks passed
@neverett neverett deleted the docs/agents-updates-ping branch February 16, 2024 16:25
neverett added a commit that referenced this pull request Feb 23, 2024
* small update to start PR

Signed-off-by: nikki everett <[email protected]>

* add airflow and snowflake agent pages and update existing agents docs

Signed-off-by: nikki everett <[email protected]>

* small updates

Signed-off-by: nikki everett <[email protected]>

* [Doc] Airflow agent deployment (#4831)

Signed-off-by: Kevin Su <[email protected]>

* [Doc] Snowflake agent deployment (#4832)

Signed-off-by: Kevin Su <[email protected]>

* copyedits

Signed-off-by: nikki everett <[email protected]>

* move agents guide to flyte

Signed-off-by: nikki everett <[email protected]>

* rename directory and add guide to toctree

Signed-off-by: nikki everett <[email protected]>

* stub out async vs sync agents content

Signed-off-by: nikki everett <[email protected]>

* link to list of agents

Signed-off-by: nikki everett <[email protected]>

* edits for sync vs async agents

Signed-off-by: nikki everett <[email protected]>

* add visible TOC table to index page

Signed-off-by: nikki everett <[email protected]>

* update for async vs sync tasks

Signed-off-by: nikki everett <[email protected]>

* Update async agent example (#4906)

* Add sync agent example

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>

* formatting and copy updates

Signed-off-by: nikki everett <[email protected]>

* fix formatting in snowflake doc, small fixes in agents procedural docs

Signed-off-by: nikki everett <[email protected]>

* fix toctree

Signed-off-by: nikki everett <[email protected]>

* add link

Signed-off-by: nikki everett <[email protected]>

* fix links

Signed-off-by: nikki everett <[email protected]>

* update link

Signed-off-by: nikki everett <[email protected]>

* import blog content

Signed-off-by: nikki everett <[email protected]>

* rename agent creation doc, small content updates

Signed-off-by: nikki everett <[email protected]>

* fix article title

Signed-off-by: nikki everett <[email protected]>

* fix link

Signed-off-by: nikki everett <[email protected]>

* undo unnecessary formatting change in unrelated file

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* small update to start PR

Signed-off-by: nikki everett <[email protected]>

* add airflow and snowflake agent pages and update existing agents docs

Signed-off-by: nikki everett <[email protected]>

* small updates

Signed-off-by: nikki everett <[email protected]>

* [Doc] Airflow agent deployment (flyteorg#4831)

Signed-off-by: Kevin Su <[email protected]>

* [Doc] Snowflake agent deployment (flyteorg#4832)

Signed-off-by: Kevin Su <[email protected]>

* copyedits

Signed-off-by: nikki everett <[email protected]>

* move agents guide to flyte

Signed-off-by: nikki everett <[email protected]>

* rename directory and add guide to toctree

Signed-off-by: nikki everett <[email protected]>

* stub out async vs sync agents content

Signed-off-by: nikki everett <[email protected]>

* link to list of agents

Signed-off-by: nikki everett <[email protected]>

* edits for sync vs async agents

Signed-off-by: nikki everett <[email protected]>

* add visible TOC table to index page

Signed-off-by: nikki everett <[email protected]>

* update for async vs sync tasks

Signed-off-by: nikki everett <[email protected]>

* Update async agent example (flyteorg#4906)

* Add sync agent example

Signed-off-by: Kevin Su <[email protected]>

* nit

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>

* formatting and copy updates

Signed-off-by: nikki everett <[email protected]>

* fix formatting in snowflake doc, small fixes in agents procedural docs

Signed-off-by: nikki everett <[email protected]>

* fix toctree

Signed-off-by: nikki everett <[email protected]>

* add link

Signed-off-by: nikki everett <[email protected]>

* fix links

Signed-off-by: nikki everett <[email protected]>

* update link

Signed-off-by: nikki everett <[email protected]>

* import blog content

Signed-off-by: nikki everett <[email protected]>

* rename agent creation doc, small content updates

Signed-off-by: nikki everett <[email protected]>

* fix article title

Signed-off-by: nikki everett <[email protected]>

* fix link

Signed-off-by: nikki everett <[email protected]>

* undo unnecessary formatting change in unrelated file

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants