Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit generated files produced by make -C docker/sandbox-bundled build #4899

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

eapolinario
Copy link
Contributor

Tracking issue

NA

Why are the changes needed?

#4869 didn't commit the generated files.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a254d3) 58.91% compared to head (920d960) 58.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4899   +/-   ##
=======================================
  Coverage   58.91%   58.91%           
=======================================
  Files         645      645           
  Lines       55351    55351           
=======================================
+ Hits        32608    32609    +1     
+ Misses      20162    20159    -3     
- Partials     2581     2583    +2     
Flag Coverage Δ
unittests 58.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 80a8765 into master Feb 14, 2024
51 checks passed
@eapolinario eapolinario deleted the add-generated-files branch February 14, 2024 03:40
katrogan pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant