-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] update outdated link to on-prem tutorial #4868
[Docs] update outdated link to on-prem tutorial #4868
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Thanks @ALMerrill! Looks like the DCO check is failing -- you should be able to sign off your commit and get the test to pass by following the steps in the "Rebase the branch" section here: https://github.com/flyteorg/flyte/pull/4868/checks?check_run_id=21381421828 |
Signed-off-by: Andrew Merrill <[email protected]>
f8be9b2
to
65c8133
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4868 +/- ##
==========================================
- Coverage 59.56% 58.97% -0.59%
==========================================
Files 567 645 +78
Lines 41536 55162 +13626
==========================================
+ Hits 24739 32533 +7794
- Misses 14402 20054 +5652
- Partials 2395 2575 +180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Congrats on merging your first pull request! 🎉 |
Signed-off-by: Andrew Merrill <[email protected]> Co-authored-by: Andrew Merrill <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Andrew Merrill <[email protected]> Co-authored-by: Andrew Merrill <[email protected]>
Tracking issue
https://github.com/flyteorg/flyte/issues/
Closes #4865
Why are the changes needed?
The link in the docs that points to the "hard way" tutorial for on-prem deployment is out of date
What changes were proposed in this pull request?
Updating the link. The link is found here, under this header: https://docs.flyte.org/en/latest/deployment/deployment/cloud_simple.html#flyte-in-on-premises-infrastructure
How was this patch tested?
The link that is being changed to is working, it just added the
single-node
folderScreenshots
Old link
New link
Check all the applicable boxes
Docs link
https://docs.flyte.org/en/latest/deployment/deployment/cloud_simple.html#flyte-in-on-premises-infrastructure