Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update outdated link to on-prem tutorial #4868

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ALMerrill
Copy link
Contributor

@ALMerrill ALMerrill commented Feb 8, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/
Closes #4865

Why are the changes needed?

The link in the docs that points to the "hard way" tutorial for on-prem deployment is out of date

What changes were proposed in this pull request?

Updating the link. The link is found here, under this header: https://docs.flyte.org/en/latest/deployment/deployment/cloud_simple.html#flyte-in-on-premises-infrastructure

How was this patch tested?

The link that is being changed to is working, it just added the single-node folder

Screenshots

Old link
image

New link
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Docs link

https://docs.flyte.org/en/latest/deployment/deployment/cloud_simple.html#flyte-in-on-premises-infrastructure

Copy link

welcome bot commented Feb 8, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 8, 2024
@neverett
Copy link
Contributor

neverett commented Feb 8, 2024

Thanks @ALMerrill! Looks like the DCO check is failing -- you should be able to sign off your commit and get the test to pass by following the steps in the "Rebase the branch" section here: https://github.com/flyteorg/flyte/pull/4868/checks?check_run_id=21381421828

Signed-off-by: Andrew Merrill <[email protected]>
@ALMerrill ALMerrill force-pushed the 4865-fix-on-prem-docs-link branch from f8be9b2 to 65c8133 Compare February 8, 2024 20:45
@eapolinario eapolinario enabled auto-merge (squash) February 8, 2024 22:15
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (104b95e) 59.56% compared to head (65c8133) 58.97%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4868      +/-   ##
==========================================
- Coverage   59.56%   58.97%   -0.59%     
==========================================
  Files         567      645      +78     
  Lines       41536    55162   +13626     
==========================================
+ Hits        24739    32533    +7794     
- Misses      14402    20054    +5652     
- Partials     2395     2575     +180     
Flag Coverage Δ
unittests 58.97% <ø> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 1b3a5cc into flyteorg:master Feb 8, 2024
48 of 49 checks passed
Copy link

welcome bot commented Feb 8, 2024

Congrats on merging your first pull request! 🎉

katrogan pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: Andrew Merrill <[email protected]>
Co-authored-by: Andrew Merrill <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Signed-off-by: Andrew Merrill <[email protected]>
Co-authored-by: Andrew Merrill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] link to on-premises guide is outdated/broken
3 participants