Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split access token into half and store to avoid "securecookie: the value is too long" error #4863

Merged
merged 7 commits into from
Mar 29, 2024

correct spelling...

3d11035
Select commit
Loading
Failed to load commit list.
Merged

Split access token into half and store to avoid "securecookie: the value is too long" error #4863

correct spelling...
3d11035
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 29, 2024 in 0s

59.10% (+0.54%) compared to d68047a

View this Pull Request on Codecov

59.10% (+0.54%) compared to d68047a

Details

Codecov Report

Attention: Patch coverage is 65.78947% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 59.10%. Comparing base (d68047a) to head (3d11035).
Report is 26 commits behind head on master.

Files Patch % Lines
flyteadmin/auth/cookie_manager.go 65.78% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4863      +/-   ##
==========================================
+ Coverage   58.56%   59.10%   +0.54%     
==========================================
  Files         494      645     +151     
  Lines       42987    55573   +12586     
==========================================
+ Hits        25176    32849    +7673     
- Misses      15816    20133    +4317     
- Partials     1995     2591     +596     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.