Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flyte docs build directions #4862

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Conversation

ppiegaze
Copy link
Member

@ppiegaze ppiegaze commented Feb 8, 2024

Update directions in contributing guide for building Flyte docs to align with new monodocs build system

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 8, 2024
@ppiegaze ppiegaze requested a review from neverett February 8, 2024 09:14
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a9e8a3) 58.97% compared to head (84c0fef) 59.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4862      +/-   ##
==========================================
+ Coverage   58.97%   59.24%   +0.26%     
==========================================
  Files         645      567      -78     
  Lines       55162    44559   -10603     
==========================================
- Hits        32533    26398    -6135     
+ Misses      20054    15766    -4288     
+ Partials     2575     2395     -180     
Flag Coverage Δ
unittests 58.34% <ø> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

neverett
neverett previously approved these changes Feb 8, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, otherwise LGTM

docs/community/contribute.rst Outdated Show resolved Hide resolved
docs/community/contribute.rst Outdated Show resolved Hide resolved
docs/community/contribute.rst Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 8, 2024
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
ppiegaze and others added 2 commits February 8, 2024 20:21
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>
@neverett neverett merged commit 4afb743 into master Feb 9, 2024
49 checks passed
@neverett neverett deleted the correct-docs-local-build-info branch February 9, 2024 21:53
katrogan pushed a commit that referenced this pull request Feb 20, 2024
* Update flyte docs build directions

Signed-off-by: Peeter Piegaze <[email protected]>

* Update docs/community/contribute.rst

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>

* Update docs/community/contribute.rst

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>

* Update docs/community/contribute.rst

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>

---------

Signed-off-by: Peeter Piegaze <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* Update flyte docs build directions

Signed-off-by: Peeter Piegaze <[email protected]>

* Update docs/community/contribute.rst

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>

* Update docs/community/contribute.rst

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>

* Update docs/community/contribute.rst

Co-authored-by: Nikki Everett <[email protected]>
Signed-off-by: Peeter Piegaze <[email protected]>

---------

Signed-off-by: Peeter Piegaze <[email protected]>
Co-authored-by: Nikki Everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants