Remove protoc_gen_swagger #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4860 +/- ##
=======================================
Coverage 58.97% 58.98%
=======================================
Files 645 645
Lines 55162 55162
=======================================
+ Hits 32533 32538 +5
+ Misses 20054 20049 -5
Partials 2575 2575
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wild-endeavor
approved these changes
Feb 8, 2024
pingsutw
approved these changes
Feb 8, 2024
katrogan
pushed a commit
that referenced
this pull request
Feb 20, 2024
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
We're fully moved to buf, this dependence is no longer needed (as it was replaced by
protoc-gen-openapiv2).What changes were proposed in this pull request?
How was this patch tested?
Tested in sandbox by generating an image that contained a version of flyteidl using the code in this PR and a doctored version of flytekit that didn't require flyteidl (so that I could install both at the same time without conflicts).
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link