Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS file and add docs team #4857

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Feb 7, 2024

Why are the changes needed?

To flag the docs team when there are docs PRs.

What changes were proposed in this pull request?

Creates a CODEOWNERS file and adds docs team members (@neverett and @ppiegaze) as reviewers for files in the /docs directory.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@neverett neverett self-assigned this Feb 7, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a9e8a3) 58.97% compared to head (30fda40) 58.97%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4857   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         645      645           
  Lines       55162    55162           
=======================================
  Hits        32533    32533           
  Misses      20054    20054           
  Partials     2575     2575           
Flag Coverage Δ
unittests 58.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 8, 2024
@neverett neverett merged commit ef8fe40 into master Feb 8, 2024
49 checks passed
@neverett neverett deleted the docs/update-docs-codeowners branch February 8, 2024 20:33
katrogan pushed a commit that referenced this pull request Feb 20, 2024
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants