Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs links for monodocs #4834

Merged
merged 13 commits into from
Feb 14, 2024
Merged

Update docs links for monodocs #4834

merged 13 commits into from
Feb 14, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Feb 5, 2024

Why are the changes needed?

Once we sunset the old docs, redirects from the old flytesnacks, flytectl, and flyteidl docs links to the new monodocs links will stop working, so we need to update the old links in all external sites.

What changes were proposed in this pull request?

Updated docs links. I did a search and replace for old links, but also tested changes manually, since some old links were 404ing.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

TBD

Docs link

TBD

@neverett neverett self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cd775a) 58.92% compared to head (d1443ab) 58.92%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4834   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files         645      645           
  Lines       55380    55380           
=======================================
  Hits        32632    32632           
  Misses      20165    20165           
  Partials     2583     2583           
Flag Coverage Δ
unittests 58.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ppiegaze
ppiegaze previously approved these changes Feb 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2024
nikki everett added 11 commits February 14, 2024 16:23
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
nikki everett added 2 commits February 14, 2024 10:04
@neverett neverett marked this pull request as ready for review February 14, 2024 16:26
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 14, 2024
@ppiegaze ppiegaze merged commit eb78b6b into master Feb 14, 2024
49 checks passed
@ppiegaze ppiegaze deleted the docs/update-docs-links branch February 14, 2024 16:37
katrogan pushed a commit that referenced this pull request Feb 20, 2024
* update docs links in main README

Signed-off-by: nikki everett <[email protected]>

* update links in contribution guide

Signed-off-by: nikki everett <[email protected]>

* update links in concepts docs

Signed-off-by: nikki everett <[email protected]>

* update docs links in community roadmap

Signed-off-by: nikki everett <[email protected]>

* update link in contribution guide

Signed-off-by: nikki everett <[email protected]>

* update link in concept doc

Signed-off-by: nikki everett <[email protected]>

* update links in deployment docs

Signed-off-by: nikki everett <[email protected]>

* update link in API docs landing page

Signed-off-by: nikki everett <[email protected]>

* update CHANGELOG links

Signed-off-by: nikki everett <[email protected]>

* update flyteidl links

Signed-off-by: nikki everett <[email protected]>

* update links in rfcs

Signed-off-by: nikki everett <[email protected]>

* update remaining old docs links

Signed-off-by: nikki everett <[email protected]>

* change flyteidl files back to master state

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
katrogan pushed a commit that referenced this pull request Feb 20, 2024
* update docs links in main README

Signed-off-by: nikki everett <[email protected]>

* update links in contribution guide

Signed-off-by: nikki everett <[email protected]>

* update links in concepts docs

Signed-off-by: nikki everett <[email protected]>

* update docs links in community roadmap

Signed-off-by: nikki everett <[email protected]>

* update link in contribution guide

Signed-off-by: nikki everett <[email protected]>

* update link in concept doc

Signed-off-by: nikki everett <[email protected]>

* update links in deployment docs

Signed-off-by: nikki everett <[email protected]>

* update link in API docs landing page

Signed-off-by: nikki everett <[email protected]>

* update CHANGELOG links

Signed-off-by: nikki everett <[email protected]>

* update flyteidl links

Signed-off-by: nikki everett <[email protected]>

* update links in rfcs

Signed-off-by: nikki everett <[email protected]>

* update remaining old docs links

Signed-off-by: nikki everett <[email protected]>

* change flyteidl files back to master state

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* update docs links in main README

Signed-off-by: nikki everett <[email protected]>

* update links in contribution guide

Signed-off-by: nikki everett <[email protected]>

* update links in concepts docs

Signed-off-by: nikki everett <[email protected]>

* update docs links in community roadmap

Signed-off-by: nikki everett <[email protected]>

* update link in contribution guide

Signed-off-by: nikki everett <[email protected]>

* update link in concept doc

Signed-off-by: nikki everett <[email protected]>

* update links in deployment docs

Signed-off-by: nikki everett <[email protected]>

* update link in API docs landing page

Signed-off-by: nikki everett <[email protected]>

* update CHANGELOG links

Signed-off-by: nikki everett <[email protected]>

* update flyteidl links

Signed-off-by: nikki everett <[email protected]>

* update links in rfcs

Signed-off-by: nikki everett <[email protected]>

* update remaining old docs links

Signed-off-by: nikki everett <[email protected]>

* change flyteidl files back to master state

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants