Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto changes #4778

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Proto changes #4778

merged 3 commits into from
Jan 25, 2024

Conversation

wild-endeavor
Copy link
Contributor

No description provided.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (bcb7abe) 58.33% compared to head (6df5a5b) 58.52%.

Files Patch % Lines
flyteadmin/pkg/rpc/adminservice/base.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4778      +/-   ##
==========================================
+ Coverage   58.33%   58.52%   +0.19%     
==========================================
  Files         626      625       -1     
  Lines       53938    53669     -269     
==========================================
- Hits        31465    31412      -53     
+ Misses      19949    19740     -209     
+ Partials     2524     2517       -7     
Flag Coverage Δ
unittests 58.52% <80.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor marked this pull request as ready for review January 25, 2024 17:18
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 25, 2024
@wild-endeavor wild-endeavor merged commit 8f516e8 into master Jan 25, 2024
45 checks passed
@wild-endeavor wild-endeavor deleted the artifact-proto-update branch January 25, 2024 18:12
pmahindrakar-oss pushed a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants