-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetTaskMetrics and GetTaskLogs to agent #4662
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4662 +/- ##
==========================================
+ Coverage 58.12% 58.16% +0.03%
==========================================
Files 626 626
Lines 53815 53786 -29
==========================================
+ Hits 31278 31282 +4
+ Misses 20035 19998 -37
- Partials 2502 2506 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -34,3 +35,32 @@ message Span { | |||
// spans defines a collection of Spans that breakdown this execution. | |||
repeated Span spans = 7; | |||
} | |||
|
|||
enum ExecutionMetric { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be challenging to anticipate or keep up with all possible metrics (and aggregations). I suspect at minimum we will want some string escape hatch, i.e., oneof {enum string}
, if not just a string encoding the query (metric + aggregation)
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment on token, but otherwise looks good
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Thank you for working on this feature. A couple of questions: Where are these used? What is the different between log links returned by the endpoint and those propagated via |
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link