Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetTaskMetrics and GetTaskLogs to agent #4662

Merged
merged 14 commits into from
Jan 9, 2024
Merged

Add GetTaskMetrics and GetTaskLogs to agent #4662

merged 14 commits into from
Jan 9, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jan 3, 2024

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b96419c) 58.12% compared to head (50b6ba0) 58.16%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4662      +/-   ##
==========================================
+ Coverage   58.12%   58.16%   +0.03%     
==========================================
  Files         626      626              
  Lines       53815    53786      -29     
==========================================
+ Hits        31278    31282       +4     
+ Misses      20035    19998      -37     
- Partials     2502     2506       +4     
Flag Coverage Δ
unittests 58.16% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flyteidl/protos/flyteidl/admin/agent.proto Show resolved Hide resolved
flyteidl/protos/flyteidl/admin/agent.proto Show resolved Hide resolved
flyteidl/protos/flyteidl/admin/agent.proto Show resolved Hide resolved
flyteidl/protos/flyteidl/admin/agent.proto Show resolved Hide resolved
@@ -34,3 +35,32 @@ message Span {
// spans defines a collection of Spans that breakdown this execution.
repeated Span spans = 7;
}

enum ExecutionMetric {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be challenging to anticipate or keep up with all possible metrics (and aggregations). I suspect at minimum we will want some string escape hatch, i.e., oneof {enum string}, if not just a string encoding the query (metric + aggregation)

andrewwdye
andrewwdye previously approved these changes Jan 5, 2024
Copy link
Contributor

@andrewwdye andrewwdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment on token, but otherwise looks good

flyteidl/protos/flyteidl/admin/agent.proto Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 5, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
andrewwdye
andrewwdye previously approved these changes Jan 8, 2024
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw merged commit d86f919 into master Jan 9, 2024
45 checks passed
@pingsutw pingsutw deleted the agent-metric branch January 9, 2024 18:54
katrogan pushed a commit that referenced this pull request Jan 12, 2024
@honnix
Copy link
Member

honnix commented Feb 5, 2024

Thank you for working on this feature. A couple of questions:

Where are these used? What is the different between log links returned by the endpoint and those propagated via Resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants