Support kuberay v1.0.0 #4656
Merged
Support kuberay v1.0.0 #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yicheng-Lu-llll <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4656 +/- ##
==========================================
- Coverage 58.11% 58.11% -0.01%
==========================================
Files 626 626
Lines 53815 53812 -3
==========================================
- Hits 31277 31275 -2
- Misses 20036 20037 +1
+ Partials 2502 2500 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Signed-off-by: Yicheng-Lu-llll <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: Yicheng-Lu-llll <[email protected]>
EngHabu
approved these changes
Jan 31, 2024
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, KubeRay is undergoing significant refactoring of the RayJob, which includes lots of status changes that Flyte depends on. This update could potentially be released in KubeRay v1.2.0. Before refactoring the current Ray plugin to be based on KubeRay v1.2.0, it would be great to first support KubeRay v1.0.0 and all earlier versions. For KubeRay v1.2.0, maintaining backward compatibility will be almost impossible due to the extensive changes in RayJob.
Additionally, the KubeRay maintainers have recently decided to continue maintaining version v1alpha1 (previously deprecated) until the release of KubeRay v1.2.0.
This PR enables users to use Kuberay v1.0.0 and all earlier versions.
What changes were proposed in this pull request?
This PR introduces several new statuses while maintaining backward compatibility.
How was this patch tested?
I have tested this PR with Kuberay v0.5.2 and Kuberay v1.0.0.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link