Correctly computing ArrayNode maximum attempts and system failures

[hamersaw]

Tracking issue

NA

Why are the changes needed?

These values are use in a bitarray to compute the number of bits to store each value. If they are incorrect the bitarray can panic on overflow.

What changes were proposed in this pull request?

These values are

How was this patch tested?

Tested with varying configured values for default-max-attempts, retries in @task decorator, max-node-retries-on-system-failures, and ignore-retry-cause.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

NA

Docs link

NA

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3501675) 59.02% compared to head (cdf07a1) 59.03%.

Files	Patch %	Lines
...ytepropeller/pkg/controller/nodes/array/handler.go	72.72%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4627      +/-   ##
==========================================
+ Coverage   59.02%   59.03%   +0.01%     
==========================================
  Files         622      622              
  Lines       52775    52780       +5     
==========================================
+ Hits        31148    31157       +9     
+ Misses      19140    19138       -2     
+ Partials     2487     2485       -2     

Flag	Coverage Δ
unittests	59.03% <72.72%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.