Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert commit to string #4599

Merged
merged 1 commit into from
Dec 14, 2023
Merged

convert commit to string #4599

merged 1 commit into from
Dec 14, 2023

Conversation

cosmicBboy
Copy link
Contributor

Fix a minor issue: git commit object should be converted to string in import_project sphinx extension.

Signed-off-by: Niels Bantilan <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 14, 2023
@thomasjpfan thomasjpfan enabled auto-merge (squash) December 14, 2023 16:22
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c84e46) 59.00% compared to head (ee6908f) 59.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4599   +/-   ##
=======================================
  Coverage   59.00%   59.00%           
=======================================
  Files         621      621           
  Lines       52498    52498           
=======================================
+ Hits        30974    30975    +1     
+ Misses      19057    19056    -1     
  Partials     2467     2467           
Flag Coverage Δ
unittests 59.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasjpfan thomasjpfan merged commit 1bed29a into master Dec 14, 2023
45 checks passed
@thomasjpfan thomasjpfan deleted the monodocs-fix-commit-str branch December 14, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants